-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audience attribute with test case #714
Conversation
@arkid15r I've made the necessary changes as expected, please review it and let me know if any changes are required :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good and the only thing I suggest to improve is to follow the properties alphabetical ordering everywhere.
@arkid15r Thank you for suggesting, i've made the properties in alphabetically order, please review and suggest if any changes are required :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Resolves #687
Added
audience
attribute to theproject.json
file, also added positive and negative test cases to test the schema file.